[REST Catalog API] Rework catalog instance rotation#338
Merged
george-zubrienko merged 3 commits intomainfrom Mar 18, 2026
Merged
[REST Catalog API] Rework catalog instance rotation#338george-zubrienko merged 3 commits intomainfrom
george-zubrienko merged 3 commits intomainfrom
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ed1473b |
s-vitaliy
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current live implementation we use
TrieMapto store catalog instances, and create a new one every now and then.getCatalogthen emits most "fresh" instance, while old one that can still be serving workloads, is kept in TrieMap.With increased number of Iceberg API calls, this approach leads to TrieMap growing to OOM amounts. Hence, let's replace this with a singleton cache via ZIO's
Cached. Since we no longer share Iceberg catalog creation (ie it is not a singleton), we can simply close the old instance and return a new one.There is still a chance to prematurely close within the same owner - I'd suggest we address this if needed by changing the refresh to
manual.