Skip to content

Comments

Rename package from internal to test#170

Merged
s-vitaliy merged 3 commits intomainfrom
package-rename
Jan 6, 2026
Merged

Rename package from internal to test#170
s-vitaliy merged 3 commits intomainfrom
package-rename

Conversation

@s-vitaliy
Copy link
Contributor

Part of #144

Scope

Package with test stream definitions was renamed from internal to test since we cannot import packages form internal folder in tests in other package.

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

@s-vitaliy s-vitaliy requested a review from a team as a code owner January 6, 2026 13:01
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

go-test-coverage report:

  below threshold:				coverage:	threshold:
  configuration/configuration.go		 0.0% (0/18)	70%
  telemetry/app_metrics.go			 0.0% (0/9)	70%

Package coverage threshold (70%) satisfied:	FAIL
  below threshold:				coverage:	threshold:
  configuration					 0.0% (0/18)	70%
  telemetry					 0.0% (0/9)	70%

Total coverage threshold (75%) satisfied:	FAIL
Total test coverage: 60.0% (54/90)

Files with uncovered lines:
  file:							coverage:	uncovered lines:
  configuration/configuration.go			0%		17-20 22-24 27-36 39-41 43-47 52-55 60
  services/controllers/stream_class/stream_class.go	85.7%		40-42 47-49 67-70 90-93 103-106 141-144
  telemetry/app_metrics.go				0%		18-22 24 53-56 60-63 65

@s-vitaliy s-vitaliy merged commit 760c225 into main Jan 6, 2026
1 of 2 checks passed
@s-vitaliy s-vitaliy deleted the package-rename branch January 6, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants