Skip to content

Comments

Add stream reconciler#171

Closed
s-vitaliy wants to merge 21 commits intomainfrom
add-stream-reconciler
Closed

Add stream reconciler#171
s-vitaliy wants to merge 21 commits intomainfrom
add-stream-reconciler

Conversation

@s-vitaliy
Copy link
Contributor

Fixes/Implements #.

Scope

Implemented:

  • Awesome new feature
  • And another awesome new feature

Additional changes:

  • Refactored AwesomeClass
  • Removed deprecated AnotherClass and get_awesomeness from AwesomeClass

Checklist

  • GitHub issue exists for this change.
  • Unit tests added and they pass.
  • Line Coverage is at least 80%.
  • Review requested on latest commit.

# Conflicts:
#	pkg/test/apis_test/streaming/v1/types.go
#	services/controllers/stream/stream_definition.go
#	services/controllers/stream/unstructured_wrapper.go
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

go-test-coverage report:

  below threshold:				coverage:	threshold:
  configuration/configuration.go		 0.0% (0/18)	70%
  services/environment_configurator.go		53.8% (7/13)	70%
  telemetry/app_metrics.go			 0.0% (0/9)	70%

Package coverage threshold (70%) satisfied:	FAIL
  below threshold:				coverage:	threshold:
  configuration					 0.0% (0/18)	70%
  services					53.8% (7/13)	70%
  telemetry					 0.0% (0/9)	70%

Total coverage threshold (75%) satisfied:	FAIL
Total test coverage: 68.2% (247/362)

Files with uncovered lines:
  file:								coverage:	uncovered lines:
  configuration/configuration.go				0%		17-20 22-24 27-36 39-41 43-47 52-55 60
  services/controllers/stream/stream_definition.go		80%		71-73
  services/controllers/stream/stream_reconciler.go		72.9%		42-44 46-49 52-55 58-60 65-68 107-108 118-122 130-132 142-144 150-153 155-158 160 166-169 173-176 182-184 187-189 196-198 203-205 207-209 219-221 231-233 238-240 248-250 253-255 261-263 266-268 275-277 294-297 315-318 321-324
  services/controllers/stream/streaming_job.go			87.5%		12-14
  services/controllers/stream/unstructured_wrapper.go		72.5%		46-48 50-52 55-57 67-70 72-75 84-86 144-146 149-151 154-156 159-161 164-166 173-175 177-179 182-184 187-189 197-202 209-211 213-215 222-227
  services/controllers/stream_class/stream_class_reconciler.go	79.4%		40-42 47-49 67-70 90-93 98-106 141-144
  services/environment_configurator.go				53.8%		24-31 33-36
  telemetry/app_metrics.go					0%		18-22 24 53-56 60-63 65

# Conflicts:
#	services/controllers/stream/basic_job_configurator.go
#	services/controllers/stream/job_builder.go
#	services/controllers/stream/stream_definition.go
#	services/job_configurator.go
#	tests/mocks/job_builder.go
# Conflicts:
#	pkg/apis/streaming/v1/extensions.go
#	services/controllers/stream/unstructured_wrapper.go
@s-vitaliy s-vitaliy closed this Jan 8, 2026
@s-vitaliy s-vitaliy deleted the add-stream-reconciler branch January 26, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant