Skip to content

Add pytyped and correct reader class annotation #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add pytyped and correct reader class annotation #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7cc889
Added py.typed to support mypy when subclassing
robinmackaij Mar 11, 2025
11d4427
Correct annotation for the reader_class argument
robinmackaij Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DataDriver/DataDriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import traceback
from glob import glob
from pathlib import Path
from typing import Any, Dict, List, Optional, Union # type: ignore
from typing import Any, Dict, List, Optional, Type, Union # type: ignore

from robot.api.logger import console # type: ignore
from robot.libraries.BuiltIn import BuiltIn # type: ignore
Expand Down Expand Up @@ -1357,7 +1357,7 @@ def __init__(
lineterminator: str = "\r\n",
*,
sheet_name: Union[str, int] = 0,
reader_class: Optional[Union[AbstractReaderClass, str]] = None,
reader_class: Optional[Union[Type[AbstractReaderClass], str]] = None,
file_search_strategy: str = "PATH",
file_regex: str = r"(?i)(.*?)(\.csv)",
include: Optional[str] = None,
Expand Down
Empty file added src/DataDriver/py.typed
View file
Open in desktop
Empty file.