Compile sansshell on windows.#233
Draft
stvnrhodes wants to merge 4 commits intoSnowflake-Labs:mainfrom
Draft
Conversation
SansShell is primarily meant for linux server management, but most of the go libraries that it uses have some windows support. Making it compile under GOOS=windows requires modest tweaks. Various unix-isms like signals and uid/gid are present in the SansShell API and can only be best-effort supported on windows. I haven't comformed that the code runs on windows. I've only confirmed that I can cross-compile for windows from linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SansShell is primarily meant for linux server management, but most of the go libraries that it uses have some windows support. Making it compile under GOOS=windows requires modest tweaks. Various unix-isms like signals and uid/gid are present in the SansShell API and can only be best-effort supported on windows.
This makes the minimal changes for tests to pass. I've skipped tests on windows when they have too much unix-specific logic.