fix(accessibilite): accessibilité: ajout du bilan 2024 rendu accessible #6890
Conversation
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
m-maillot
changed the title
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
This PR adds a new "Resume" component to display annual reports on the stats page. The implementation is functional but has several issues:
CRITICAL:
- Hardcoded data in production code (year, filename, file size) should be dynamic or configurable
- Missing accessibility: empty
imageAltprop violates WCAG guidelines
IMPORTANT:
- Snapshot test doesn't verify actual component behavior - it only captures HTML output
- No unit tests for the new Resume component
- Typo in image filename ("modeles-de-courriers" should likely be "modeles-de-courrier")
The changes follow the existing code style but need improvements in testability, accessibility, and data management.
| title={`Télécharger le bilan annuel de l’année ${year}`} | ||
| titleAs={`h3`} | ||
| detail={<p>Format PDF - {fileSizeMb}Mo</p>} | ||
| imageAlt={""} |
There was a problem hiding this comment.
CRITICAL - Accessibility violation: Empty imageAlt prop fails WCAG accessibility standards. All images must have meaningful alternative text for screen readers. Consider using a descriptive alt text like 'Icône de téléchargement de document PDF' or make this decorative by using aria-hidden="true" on the image if the download context is already clear from the title.
| imageAlt={""} | |
| imageAlt={"Icône de téléchargement de document PDF"} |
| enlargeLinkOrButton | ||
| imageSvg={false} | ||
| small | ||
| imageUrl={`/static/assets/img/modeles-de-courriers-download.svg`} |
There was a problem hiding this comment.
MINOR - Potential typo: The filename contains 'modeles-de-courriers-download.svg' with 'courriers' (plural). Verify if this should be 'courrier' (singular) to match French grammar conventions, as 'modèle de courrier' is the standard form.
| imageUrl={`/static/assets/img/modeles-de-courriers-download.svg`} | |
| imageUrl={`/static/assets/img/modeles-de-courrier-download.svg`} |
|
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
An error occurred: Error processing line comments: GitHub API error (422): {"message":"Validation Failed","errors":[{"resource":"PullRequestReviewComment","code":"custom","field":"pull_request_review_thread.line","message":"could not be resolved"}],"documentation_url":"https://docs.github.com/rest/pulls/comments#create-a-review-comment-for-a-pull-request","status":"422"}. Comment params: path=packages/code-du-travail-frontend/src/modules/stats/index.tsx, line=11, startLine=6
|
🎉 Deployment for commit 399d43d : IngressesDocker images
|
No description provided.