WIP - linked to cdtn admin #7110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmelisson
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
revu-bot
reviewed
Feb 10, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
Summary
This WIP PR introduces changes to search functionality and IDCC handling. The review identifies 3 critical issues and 2 important concerns that need attention:
Critical Issues
- Unused import causing potential build failures
- Debug console.log left in production code
- Type safety regression in IDCC parsing (parseFloat → parseInt)
Important Issues
- Commented-out code should be removed or documented
- Incomplete TODO comment needs clarification
Overall Assessment
The PR shows good progress on search improvements, but contains debugging artifacts and incomplete refactoring that should be addressed before merging.
|
revu-bot
reviewed
Feb 10, 2026
Comment on lines
4
to
+5
| import { PresearchClass, PreSearchResult, SEARCH_ALGO } from "./types"; | ||
| import { format } from "path"; |
Collaborator
There was a problem hiding this comment.
[CRITICAL] Unused import will cause build failures
- Why it matters: This unused import from 'path' module will trigger linting errors and potentially break the build
- Impact: Build pipeline failure, code quality degradation
- Action required: Remove this import as it's not used anywhere in the file
Suggested change
| import { PresearchClass, PreSearchResult, SEARCH_ALGO } from "./types"; | |
| import { format } from "path"; | |
| import { PresearchClass, PreSearchResult, SEARCH_ALGO } from "./types"; |
revu-bot
reviewed
Feb 10, 2026
Comment on lines
+14
to
+16
| const pq = this.searchParams.get("pq"); | ||
| console.log({ q, pq }); | ||
| const response = await searchWithQuery(q as string, 5, pq != "false"); |
Collaborator
There was a problem hiding this comment.
[CRITICAL] Debug console.log left in production code
- Why it matters: Console logs in production expose internal query parameters and degrade performance
- Security concern: May leak sensitive search patterns or user behavior
- Action required: Remove this debug statement before merging
Suggested change
| const pq = this.searchParams.get("pq"); | |
| console.log({ q, pq }); | |
| const response = await searchWithQuery(q as string, 5, pq != "false"); | |
| const pq = this.searchParams.get("pq"); | |
| const response = await searchWithQuery(q as string, 5, pq != "false"); |
revu-bot
reviewed
Feb 10, 2026
Comment on lines
+246
to
+253
| // { | ||
| // match: { | ||
| // source: { | ||
| // boost: 1.1, | ||
| // query: SOURCES.SHEET_SP, | ||
| // }, | ||
| // }, | ||
| // }, |
Collaborator
There was a problem hiding this comment.
[IMPORTANT] Commented-out code should be removed or documented
- Why it matters: Commented code creates confusion about intent and clutters the codebase
- Options:
- If this boost is no longer needed, remove it entirely
- If it's temporarily disabled for testing, add a TODO with context and timeline
- If it's for future reference, move to documentation or git history
Recommendation: Either remove completely or add a clear comment explaining why it's disabled and when it should be reconsidered.
rmelisson
temporarily deployed
to
review-auto
GitHub Actions
Inactive
|
🎉 Deployment for commit 9a55999 : Docker images
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.