Open
Conversation
olivier-rabot
temporarily deployed
to
review-auto
GitHub Actions
Inactive
revu-bot
reviewed
Feb 18, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
Review Summary
This PR implements a workaround for screen reader vocalization of toast notifications by creating a separate live region. While the approach addresses the immediate accessibility issue, there are several CRITICAL and IMPORTANT concerns that need attention:
| Severity | Issue | Impact |
|---|---|---|
| CRITICAL | Missing Vue imports | Code will fail at runtime |
| IMPORTANT | Race condition with nested timeouts | Unreliable screen reader announcements |
| IMPORTANT | Toast removal not handled | Memory leak and stale announcements |
| MINOR | Magic numbers without explanation | Reduced maintainability |
The core strategy (separate live region + aria-live="off" on alerts) is sound, but the implementation needs refinement for production reliability.
achorein
approved these changes
Feb 19, 2026
sweetyume
reviewed
Feb 19, 2026
| <div | ||
| v-if="liveMessage" | ||
| role="status" | ||
| aria-live="polite" |
There was a problem hiding this comment.
rendre dynamique l'aria-live, sinon on perd la logique alert -> aria-live=assertive et polite -> aria-live=polite
achorein
force-pushed
the
fix/1223-rgaa-restitution-toaster
branch
from
035c839 to
36f3e7d
Compare
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
achorein
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
|
|
🎉 Deployment for commit 36f3e7d : Ingresses
Docker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) lié(s)
https://jira-mcas.atlassian.net/jira/software/c/projects/VAO/boards/336?selectedIssue=VAO-1233
Description
Force la restitution des toasts
Screenshot / liens loom
Check-list
console.log<script lang="ts">Testing instructions