Skip to content

feat: 764 - Intégration S3 step 2#1198

Draft
achorein wants to merge 1 commit intomainfrom
feat/764-get-file-from-s3
Draft

feat: 764 - Intégration S3 step 2#1198
achorein wants to merge 1 commit intomainfrom
feat/764-get-file-from-s3

Conversation

@achorein
Copy link
Contributor

Ticket(s) lié(s)

https://jira-mcas.atlassian.net/browse/VAO-764?atlOrigin=eyJpIjoiY2NkMDJlNmQwYzc2NDNjOTg3OWU0MzE3ODQzODZmN2MiLCJwIjoiaiJ9

Description

Lors du téléchargement des documents il faut maintenant :

Récupérer les documents depuis le bucket S3.

Si le document n’existe sur S3 :

on envoi une erreur sentry pour tracer les documents manquants

on essaye de télécharger le document depuis la base de données en fallback

Screenshot / liens loom

Check-list

  • Ma branche est rebase sur main
  • Des tests ont été écrits pour tous les endpoints créés ou modifiés
  • Refacto "à la volée" des parties sur lesquelles j'ai codée
  • Plus de console.log
  • J'ai ajouté une validation de schéma sur la route que j'ai ajouté ou modifié
  • J'ai converti les fichiers vue en <script lang="ts">
  • Mon code est en Typescript (autant que possible)

Testing instructions

@achorein achorein self-assigned this Feb 23, 2026
@revu-bot revu-bot bot requested a review from revu-bot February 23, 2026 09:32
@achorein achorein force-pushed the feat/764-get-file-from-s3 branch from 60ce37d to d991ca7 Compare February 23, 2026 11:00
@achorein achorein temporarily deployed to build-review-auto February 23, 2026 11:00 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 23, 2026 11:00 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 23, 2026 11:00 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 23, 2026 11:00 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 23, 2026 11:00 — with GitHub Actions Inactive
@achorein achorein force-pushed the feat/764-get-file-from-s3 branch from d991ca7 to 62ef368 Compare February 24, 2026 13:09
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@achorein achorein temporarily deployed to build-review-auto February 24, 2026 13:09 — with GitHub Actions Inactive
@socket-security
Copy link

socket-security bot commented Feb 24, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addeddayjs@​1.11.1310010010084100

View full report

@tokenbureau
Copy link

tokenbureau bot commented Feb 24, 2026

🎉 Deployment for commit 34b26b9 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/backend:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/cron:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/external-api:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-bo:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-usagers:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/migrations:sha-34b26b95414fbdf22022fe06ec8b2c4fb7cad6bf
  • 📦 docker pull maildev/maildev:2.1.0
Debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant