Skip to content

use RelayState from parameters when present as the state, fallback to default otherwise.#1411

Merged
atymic merged 3 commits intoSocialiteProviders:masterfrom
biswajit287:saml-relaystate-handling
Dec 15, 2025
Merged

use RelayState from parameters when present as the state, fallback to default otherwise.#1411
atymic merged 3 commits intoSocialiteProviders:masterfrom
biswajit287:saml-relaystate-handling

Conversation

@biswajit287
Copy link
Copy Markdown
Contributor

@biswajit287 biswajit287 commented Dec 15, 2025

This PR changes behavior so that only explicitly provided RelayState values are used as state. Missing or empty values now fall back to the default state generation.

For more info checkout this issue

Copy link
Copy Markdown
Contributor

@27pchrisl 27pchrisl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be simplified like this? If this is all this change needs then it can be merged. Thanks for the PR!

@27pchrisl
Copy link
Copy Markdown
Contributor

@atymic looks good to me!

@atymic
Copy link
Copy Markdown
Member

atymic commented Dec 15, 2025

Thanks @27pchrisl and @biswajit287

@atymic atymic merged commit af5c815 into SocialiteProviders:master Dec 15, 2025
4 checks passed
@biswajit287
Copy link
Copy Markdown
Contributor Author

Hi @atymic, thanks for merging the PR. Do you have an estimate for when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants