Feature/kanidm allow ability to enable PKCE#1420
Closed
eric-hansen wants to merge 2 commits intoSocialiteProviders:masterfrom
Closed
Feature/kanidm allow ability to enable PKCE#1420eric-hansen wants to merge 2 commits intoSocialiteProviders:masterfrom
eric-hansen wants to merge 2 commits intoSocialiteProviders:masterfrom
Conversation
|
Thanks for submitting a PR! In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR from a personal GitHub account with maintainer permissions enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kanidm heavily encourages PKCE for OAuth2 clients. While one can disable PKCE for legacy support, this poses a security concern, and there is no guarantee this feature will continue.
Really, I am not sure if this is the best way to approach this, but it seemed clean enough. I didn't see a reason why this couldn't be set up as a config option. Kanidm treats OAuth2 setups as clients themselves (e.g., an app that uses Kanidm either needs to create a new OAuth2 client in Kanidm or use grouping trickery).