Added logic to Ensure the repo is marked as safe for git (prevents SH… #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A empty/dubious ownership errors)
dacoburn
requested review from
nolanlawson and
jfblaa
and removed request for
a team
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.35.dev1Docker image: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused GitPython to fail in CI environments due to "dubious ownership" errors when the repository directory was not marked as safe in git config. This resulted in broken pipe and SHA empty errors during CLI execution.
Root Cause
GitPython requires the repository directory to be listed in git's global safe.directory config when running in some CI containers. If not, operations like commit lookup fail with errors. Previously, the code did not check or set this config, leading to failures in certain environments.
Fix
Added a helper function to check if the repository directory is already marked as safe in git config. If not, the function adds it before initializing the Repo object. This prevents the SHA empty/dubious ownership errors and ensures reliable operation in CI and local environments.
Public Changelog
N/A