Skip to content

Conversation

@rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Nov 11, 2025

About the Contributor

This pull request is posted on behalf of SuperFlyTv

Type of Contribution

This is a code improvement

Current Behavior

If you try to use a forked version of this project in your package.json, for example by adding:

		"atem-connection": "github:Sofie-Automation/sofie-atem-connection#rjmunro/install-from-git"

It would fail because it didn't know it had to build.

New Behavior

It will build the package after installing from git.

I've modified the npm publish process a bit to

Testing Instructions

Create a trivial project in yarn and add this branch as a dependency:

yarn init
yarn add atem-connection@github:Sofie-Automation/sofie-atem-connection#rjmunro/install-from-git

Then check that it works. (TODO: Expand this)

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rjmunro rjmunro force-pushed the rjmunro/install-from-git branch from d5a1dfc to 0061b46 Compare November 11, 2025 22:29
It's already been run before. We do still need to run pinst, so we do
that manually.
@rjmunro rjmunro force-pushed the rjmunro/install-from-git branch from 0061b46 to 7544c9e Compare November 11, 2025 22:30
@rjmunro
Copy link
Contributor Author

rjmunro commented Nov 11, 2025

@Julusian I've removed the re-enable and rebased this. The other PR already included some of this one, so this is now only the optimisation to the release process.

@rjmunro rjmunro requested a review from Julusian November 11, 2025 22:31
@rjmunro rjmunro changed the title feat: Allow installing direct from git repository feat: Allow installing direct from git repository (publish.yaml‎ fix) Nov 11, 2025
@rjmunro rjmunro marked this pull request as ready for review November 11, 2025 22:33
@Julusian Julusian merged commit ebbbcc5 into main Nov 12, 2025
14 checks passed
@Julusian Julusian deleted the rjmunro/install-from-git branch November 12, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants