Fix: Ensure keyer properties are set before putting on air #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmunro
changed the title
rjmunro
changed the title
4 tasks
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
2 times, most recently
from
db06cb1 to
fe08343
Compare
nytamin
approved these changes
Sep 29, 2025
Member
nytamin
left a comment
nytamin
left a comment
There was a problem hiding this comment.
Looks good, just waiting for Sofie-Automation/sofie-atem-connection#178 before merging this.
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
2 times, most recently
from
b1c85c2 to
57d57b0
Compare
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
2 times, most recently
from
080c106 to
188eaf8
Compare
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
from
188eaf8 to
75ceb2f
Compare
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
from
75ceb2f to
20bef7c
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Julusian
reviewed
Dec 8, 2025
4 tasks
Add inputTalkbackMuted property in fairlight.
To version that supports run-order-groups
OnAir command should run after other commands when turning on, and before other commands when turning off so that key is not on air when it’s other settings are being changed.
rjmunro
force-pushed
the
rjmunro/atem-run-order-groups
branch
from
20bef7c to
03fecb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a Bug fix.
Current Behavior
If a new state changes both the input to a keyer and it's on air state you may get a single frame of the old input before the new input is loaded. This is a problem that manifests when both commands are sent to the ATEM in the same batch.
New Behavior
The onAir state for keyers is now sent in a separate batch to other commands to the ATEM. When turning on it will run last, when turing off it will run first.
Testing Instructions
Other Information
Requires Sofie-Automation/sofie-atem-connection#178 to be merged and then a version bump of sofie-atem-connection.
Status