Skip to content

Conversation

@jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Nov 15, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Build script improvement

Current Behavior

yarn prepareChangelog and yarn release fail on Windows with an unclear error. checkForMultipleVersions.mjs script is only really ran in GitHub CI

New Behavior

checkForMultipleVersions is included as a part of validate:release and beautified a bit. A yarn script is improved for it's compatibility with Windows.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the release procedure.

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner November 15, 2024 14:04
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.97%. Comparing base (d908ac6) to head (9636051).

Additional details and impacted files
@@            Coverage Diff             @@
##           release51    #1321   +/-   ##
==========================================
  Coverage      57.96%   57.97%           
==========================================
  Files            525      525           
  Lines          84951    84951           
  Branches        4443     4463   +20     
==========================================
+ Hits           49245    49248    +3     
- Misses         35673    35679    +6     
+ Partials          33       24    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl changed the title fix(release scripts): improve release scripts fix(release scripts): improve release scripts (SOFIE-3572) Nov 25, 2024
@jstarpl jstarpl requested a review from nytamin November 29, 2024 15:55
@jstarpl jstarpl merged commit 9f9b6e7 into release51 Dec 4, 2024
76 of 78 checks passed
@jstarpl jstarpl deleted the fix/release-scripts branch December 4, 2024 10:12
@jstarpl jstarpl restored the fix/release-scripts branch December 4, 2024 10:12
@jstarpl jstarpl deleted the fix/release-scripts branch December 4, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants