Skip to content

Conversation

@jstarpl
Copy link
Contributor

@jstarpl jstarpl commented Nov 25, 2024

About the Contributor

This pull request is posted on behalf of myself.

Type of Contribution

This is a:

Documentation improvement

Current Behavior

The documentation is outdated

New Behavior

I've made a best-effort attempt at fixing the documentation for quickly setting up a Sofie Core server using docker compose.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

  • This PR affects the documentation

Time Frame

Not applicable, but the broken documentation is shown as "current" on the website.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner November 25, 2024 15:38
@jstarpl jstarpl changed the title chore: update "Quick install" / Installing Sofie Server Core page chore: update "Quick install" / Installing Sofie Server Core documentation page Nov 25, 2024
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.01%. Comparing base (3e93a5f) to head (276462c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   57.26%   58.01%   +0.75%     
==========================================
  Files         513      525      +12     
  Lines       82842    85094    +2252     
  Branches     4170     4435     +265     
==========================================
+ Hits        47438    49367    +1929     
- Misses      35371    35695     +324     
+ Partials       33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 34bb63a into master Nov 29, 2024
73 of 77 checks passed
@jstarpl jstarpl deleted the chore/update-user-guide branch November 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants