Skip to content

Conversation

@Julusian
Copy link
Member

@Julusian Julusian commented Dec 10, 2024

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

Some interlaced clips can be detected by sofie to not be interlaced.

This implements the solution as discussed in Sofie-Automation/sofie-package-manager#130 for this

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 10, 2024
@Julusian Julusian requested a review from a team as a code owner December 10, 2024 10:02
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.38%. Comparing base (a96f615) to head (6b36d5b).
Report is 178 commits behind head on release52.

Additional details and impacted files
@@             Coverage Diff             @@
##           release52    #1340    +/-   ##
===========================================
  Coverage      60.38%   60.38%            
===========================================
  Files            461      461            
  Lines          79534    79547    +13     
  Branches        4492     5064   +572     
===========================================
+ Hits           48027    48037    +10     
- Misses         31386    31387     +1     
- Partials         121      123     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 57ddfde into Sofie-Automation:release52 Dec 10, 2024
45 of 46 checks passed
@Julusian Julusian deleted the upstream/interlaced-fix branch December 10, 2024 10:47
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants