Skip to content

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

There was a typo in #1347 which is causing a type error

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 17, 2024
@Julusian Julusian requested a review from a team as a code owner December 17, 2024 15:55
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (aa3332a) to head (7f1bc02).
Report is 142 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/lib/rest/v1/studios.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1348      +/-   ##
=============================================
- Coverage      56.46%   56.45%   -0.02%     
=============================================
  Files            401      401              
  Lines          71980    71980              
  Branches        4554     4128     -426     
=============================================
- Hits           40646    40637       -9     
- Misses         31086    31221     +135     
+ Partials         248      122     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit c6be9f5 into Sofie-Automation:release52 Dec 17, 2024
32 of 34 checks passed
@Julusian Julusian deleted the upstream/fix-typo-1347 branch January 8, 2025 14:41
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants