Skip to content

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

In development, the sofie logo is not showing in the ui

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

This was broken by #1332, which renamed the default logo file to resolve an issue where the logo selection in the settings was not being respected (I think broken by #1230, when changing how static files are served)

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 18, 2024
@Julusian Julusian requested a review from a team as a code owner December 18, 2024 12:53
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (7f1bc02) to head (8704ff8).
Report is 68 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1350      +/-   ##
=============================================
+ Coverage      56.45%   56.46%   +0.01%     
=============================================
  Files            401      401              
  Lines          71980    71984       +4     
  Branches        4128     4556     +428     
=============================================
+ Hits           40637    40648      +11     
+ Misses         31221    31088     -133     
- Partials         122      248     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 2bb0dc8 into Sofie-Automation:release52 Dec 18, 2024
34 checks passed
@Julusian Julusian deleted the upstream/fix-logo-not-showing-in-dev branch January 8, 2025 14:41
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants