Skip to content

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Code improvement

New Behavior

Some small tidying to convert some simple components to be functional.

Make sure to hide whitespace changes when reviewing, over half the change is just whitespace.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team as a code owner December 18, 2024 15:16
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (7f1bc02) to head (8c5c933).
Report is 68 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1351      +/-   ##
=============================================
+ Coverage      56.45%   56.47%   +0.01%     
=============================================
  Files            401      401              
  Lines          71980    71984       +4     
  Branches        4128     4551     +423     
=============================================
+ Hits           40637    40650      +13     
- Misses         31221    31233      +12     
+ Partials         122      101      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Jan 6, 2025
@nytamin nytamin merged commit b20b4a4 into Sofie-Automation:release52 Jan 8, 2025
33 of 34 checks passed
@Julusian Julusian deleted the upstream/convert-some-components branch January 8, 2025 14:41
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants