Skip to content

Conversation

@mint-dewit
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC.

Type of Contribution

This is a: Feature Improvement

Current Behavior

Moving the next line using keyboard shortcuts or from Blueprints will ignore any QuickLoop markings.

New Behavior

Moving the next line using keyboard shortcuts or from Blueprints will keep the Next line inside of the QuickLoop bounds unless explicitly told to ignore them.

Testing

No additional unit tests have been added.

Affected areas

QuickLoop and any moveNext actions

Other Information

As reviewed by @Julusian in bbc#31

@mint-dewit mint-dewit added ✨ enhancement New feature or request Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) labels Jan 7, 2025
@mint-dewit mint-dewit requested a review from a team as a code owner January 7, 2025 15:19
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 35.76642% with 88 lines in your changes missing coverage. Please review.

Project coverage is 55.71%. Comparing base (8c5c933) to head (b87cd9f).
Report is 64 commits behind head on release52.

Files with missing lines Patch % Lines
...ker/src/playout/model/services/QuickLoopService.ts 4.47% 64 Missing ⚠️
...orker/src/blueprints/context/OnSetAsNextContext.ts 12.50% 7 Missing ⚠️
.../job-worker/src/blueprints/context/adlibActions.ts 12.50% 7 Missing ⚠️
...c/playout/model/implementation/PlayoutModelImpl.ts 30.00% 7 Missing ⚠️
meteor/server/api/userActions.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1354      +/-   ##
=============================================
- Coverage      56.47%   55.71%   -0.76%     
=============================================
  Files            401      384      -17     
  Lines          71984    68508    -3476     
  Branches        4551     4203     -348     
=============================================
- Hits           40650    38171    -2479     
+ Misses         31233    30204    -1029     
- Partials         101      133      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit bd3aeaa into Sofie-Automation:release52 Jan 7, 2025
32 of 34 checks passed
@mint-dewit mint-dewit deleted the upstream/feat-move-next-in-quickloop branch January 13, 2025 13:43
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution ✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants