feat: Rundown information in actions #1524
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmunro
changed the title
jstarpl
reviewed
Sep 15, 2025
Comment on lines
54
to
55
| /** The max number of parts returned. */ | ||
| limit?: number |
There was a problem hiding this comment.
I like that the implementation of this interface has a reasonable default of 5, but I think the fact that there is a default has to be documented here (maybe not necessarily what the default is, but that there is a default?).
Alternatively, just mandating that you need to provide your own limit would be fine too, I think.
There was a problem hiding this comment.
I've updated the JSDoc
So that an action can be taken based on what items may be coming up (further ahead than the next part instance)
rjmunro
force-pushed
the
rjmunro/rundown-in-actions
branch
from
08494df to
08942f8
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a Feature
Current Behavior
N/A
New Behavior
ActionContexts now contain a method getUpcomingParts which will return a list of upcoming parts after the next one, allowing actions to be taken based on what items may be coming up further ahead than the next part instance.
Testing
Affected areas
This PR affects what information is easily available to blueprints.
Time Frame
Other Information
Status