feat: cue from anywhere #1573
+1,733
−481
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| jest.mock('../../findObjects') | ||
| import { context, TfindLookaheadObjectsForPart } from './helpers/mockSetup.js' | ||
| import { findLookaheadForLayer } from '../../findForLayer.js' | ||
| import { expectInstancesToMatch } from '../utils.js' | ||
| import { findForLayerTestConstants } from './constants.js' | ||
| import { findLookaheadObjectsForPart } from '../../findObjects.js' | ||
|
|
||
| const findLookaheadObjectsForPartMockBase = findLookaheadObjectsForPart as TfindLookaheadObjectsForPart | ||
| const findLookaheadObjectsForPartMock = findLookaheadObjectsForPartMockBase.mockImplementation(() => []) // Default mock | ||
|
|
||
| beforeEach(() => { | ||
| findLookaheadObjectsForPartMock.mockReset() | ||
| }) | ||
|
|
||
| const current = findForLayerTestConstants.current | ||
| const nextFuture = findForLayerTestConstants.nextFuture | ||
| const layer = findForLayerTestConstants.layer | ||
|
|
||
| describe('findLookaheadForLayer – basic behavior', () => { | ||
| test('no parts', () => { | ||
| const res = findLookaheadForLayer(context, {}, [], 'abc', 1, 1) | ||
|
|
||
| expect(res.timed).toHaveLength(0) | ||
| expect(res.future).toHaveLength(0) | ||
| }) | ||
| test('if the previous part is unset', () => { | ||
| findLookaheadObjectsForPartMock.mockReturnValue([]) | ||
|
|
||
| findLookaheadForLayer(context, { previous: undefined, current, next: nextFuture }, [], layer, 1, 1) | ||
|
|
||
| expect(findLookaheadObjectsForPartMock).toHaveBeenCalledTimes(2) | ||
| expectInstancesToMatch(findLookaheadObjectsForPartMock, 1, layer, current, undefined) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { getRandomString } from '@sofie-automation/corelib/dist/lib' | ||
| import { PartInstanceAndPieceInstances, PartAndPieces } from '../../util.js' | ||
| import { createFakePiece } from '../utils.js' | ||
|
|
||
| const layer: string = getRandomString() | ||
|
|
||
| export const findForLayerTestConstants = { | ||
| previous: { | ||
| part: { _id: 'pPrev', part: 'prev' }, | ||
| allPieces: [createFakePiece('1'), createFakePiece('2'), createFakePiece('3')], | ||
| onTimeline: true, | ||
| nowInPart: 2000, | ||
| } as any as PartInstanceAndPieceInstances, | ||
| current: { | ||
| part: { _id: 'pCur', part: 'cur' }, | ||
| allPieces: [createFakePiece('4'), createFakePiece('5'), createFakePiece('6')], | ||
| onTimeline: true, | ||
| nowInPart: 1000, | ||
| } as any as PartInstanceAndPieceInstances, | ||
| nextTimed: { | ||
| part: { _id: 'pNextTimed', part: 'nextT' }, | ||
| allPieces: [createFakePiece('7'), createFakePiece('8'), createFakePiece('9')], | ||
| onTimeline: true, | ||
| } as any as PartInstanceAndPieceInstances, | ||
| nextFuture: { | ||
| part: { _id: 'pNextFuture', part: 'nextF' }, | ||
| allPieces: [createFakePiece('10'), createFakePiece('11'), createFakePiece('12')], | ||
| onTimeline: false, | ||
| } as any as PartInstanceAndPieceInstances, | ||
|
|
||
| orderedParts: [{ _id: 'p1' }, { _id: 'p2', invalid: true }, { _id: 'p3' }, { _id: 'p4' }, { _id: 'p5' }].map( | ||
| (p) => ({ | ||
| part: p as any, | ||
| usesInTransition: true, | ||
| pieces: [{ _id: p._id + '_p1' } as any], | ||
| }) | ||
| ) as PartAndPieces[], | ||
|
|
||
| layer, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { setupDefaultJobEnvironment } from '../../../../../__mocks__/context.js' | ||
| import { findLookaheadObjectsForPart } from '../../../../../playout/lookahead/findObjects.js' | ||
|
|
||
| export type TfindLookaheadObjectsForPart = jest.MockedFunction<typeof findLookaheadObjectsForPart> | ||
|
|
||
| export const context = setupDefaultJobEnvironment() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing validation for
timeOffsetandisInstanceparameters.The validation callback only checks
rundownPlaylistIdandnextPartOrInstanceId, but omitstimeOffsetandisInstance. Every other method in this class validates all incoming parameters (e.g.,takevalidatesfromPartInstanceIdwithMatch.OneOf). Without these checks, malformed inputs bypass Meteor's type enforcement.Proposed fix
() => { check(rundownPlaylistId, String) check(nextPartOrInstanceId, String) + check(timeOffset, Match.OneOf(Number, null)) + check(isInstance, Match.OneOf(Boolean, null)) },📝 Committable suggestion
🤖 Prompt for AI Agents