feat: update to target eslint 9 and node 20 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytamin
approved these changes
Jan 22, 2025
| "ts-jest": "^29.0.5", | ||
| "ts-node": "^10.9.1", | ||
| "typescript": "^4.9.5" | ||
| "@sofie-automation/code-standard-preset": "github:SuperFlyTV/sofie-code-standard-preset#commit=83e28ec8c6e0ea6287c20814f5dcb0cde1226b3d", |
Member
There was a problem hiding this comment.
Note to self: remember to update this to a proper version number after having merged the PR Sofie-Automation/sofie-code-standard-preset#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Feature / Code improvement
Current Behavior
This library is written for eslint 8
New Behavior
This updates it to require eslint 9 and node 20.
While not strictly necessary to be compatible with eslint 9, this avoids dependency pollution by using a version of
@typescript-eslint/utilsthat requires node 20I'm not sure what to do about the git dependency on a fork of
@sofie-automation/code-standard-preset. They both need the updated versions of each other, so need to be done in tandemTesting Instructions
Other Information
Status