fix: typo in config.ts: WORKER_NETWORK_ID -> WORKER_RESOURCE_ID#268
fix: typo in config.ts: WORKER_NETWORK_ID -> WORKER_RESOURCE_ID#268
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
WalkthroughUpdated the default environment variable name for the worker resource identifier in the configuration from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



About Me
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix
Current Behavior
env
WORKER_RESOURCE_IDapplies to both resourceId and networkIds of workers.New Behavior
WORKER_NETWORK_IDapplies to networkIdsWORKER_RESOURCE_IDapplies to resourceIdStatus
Summary
This PR fixes a configuration bug in
shared/packages/api/src/config.tswhere theWORKER_RESOURCE_IDenvironment variable was incorrectly being used as the default value for both theresourceIdandnetworkIdsworker arguments.Changes
File modified:
shared/packages/api/src/config.tsThe
networkIdsfield inworkerArgumentsGenericnow correctly uses the dedicatedWORKER_NETWORK_IDenvironment variable instead ofWORKER_RESOURCE_ID. This allows:WORKER_RESOURCE_IDto apply exclusively to the worker's resource/computer identifierWORKER_NETWORK_IDto apply exclusively to the worker's network identifiersThe change is minimal (1 line changed) and affects only the default environment variable mapping for the
networkIdsconfiguration option. All existing logic, error handling, and API signatures remain unchanged.