Skip to content

Fixed news view page #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SilverFire wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed news view page #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion controllers/SiteController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
use Yii;
use yii\base\Module;
use yii\data\ActiveDataProvider;
use yii\db\ActiveQuery;
use yii\web\Controller;

class SiteController extends Controller
Expand Down Expand Up @@ -56,7 +57,13 @@ public function actionView()
{
return $this->render('view', [
'newsDataProvider' => new ActiveDataProvider([
'query' => News::find()->orderBy('id desc'),
'query' => News::find()
->with(['tags' => function ($query) {
/** @var ActiveQuery $query */
$query->with('news');
}])
// ->with('tags.news') // the same as above
->orderBy('id desc'),
Copy link

@cebe cebe Jun 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reduce the overhead of instantiating the News AR instances for tags the following asArray() call can be added:

      'query' => News::find()->with(['tags' => function($q) {
          /** @var ActiveQuery $q */
          $q->with(['news' => function($q) {
              /** @var ActiveQuery $q */
              $q->asArray();
          }]);
      }])->orderBy('id desc'),

'pagination' => [
'pageSize' => 100,
],
Expand Down