fix(DATAGO-123661): update base components for pro code form#1094
fix(DATAGO-123661): update base components for pro code form#1094RohanSreelesh merged 3 commits intomainfrom
Conversation
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-1094! |
lgh-solace
left a comment
lgh-solace
left a comment
There was a problem hiding this comment.
Just the one question about whether the placeholder variant should be "mixable" with some of the others?
Thanks!
| notFound: <NotFoundIllustration width={150} height={150} />, | ||
| loading: <Spinner size="large" />, | ||
| noImage: null, | ||
| placeholder: null, |
There was a problem hiding this comment.
Would this placeholder variant ever be used with one of the others variants like... with loading? You would get the same effect by just passing in a class name of rounded-md bg-[var(--color-background-w20)] and then still be able to combine it with other variants?
There was a problem hiding this comment.
true I removed it
| export const messageColourVariants = { | ||
| error: "bg-[var(--color-error-w20)] text-[var(--color-error-wMain)] border-[var(--color-error-wMain)] dark:bg-[var(--color-error-w100)]/60 dark:text-[var(--color-white)] dark:border-[var(--color-error-wMain)]", | ||
| warning: "bg-[var(--color-warning-w10)] text-[var(--color-warning-wMain)] border-[var(--color-warning-wMain)] dark:bg-[var(--color-warning-w100)]/60 dark:text-[var(--color-white)] dark:border-[var(--color-warning-wMain)]", | ||
| warning: "bg-[var(--color-warning-w10)] text-foreground border-[var(--color-warning-wMain)] dark:bg-[var(--color-warning-w100)]/60 dark:text-[var(--color-white)] dark:border-[var(--color-warning-wMain)]", |
There was a problem hiding this comment.
Oky doke, maybe you can take a quick look at other usages of this warning text colour in enterprise to just make sure none of them are requiring the warning yellow?
There was a problem hiding this comment.
it is being used, I made the change local only for warning banner
lgh-solace
left a comment
lgh-solace
left a comment
There was a problem hiding this comment.
Ok, thanks! We can hopefully take a look at making our colour usage a bit nicer in another iteration. This banner is a bit crunchy.
|
2 participants
What is the purpose of this change?
Updated base components according to UX feedback:
How was this change implemented?
Key Design Decisions (optional - delete if not applicable)
How was this change tested?
Is there anything the reviewers should focus on/be aware of?