refactor(DATAGO-126701): Enhance error handling and messaging in PromptBuilderChat components#1275
Merged
refactor(DATAGO-126701): Enhance error handling and messaging in PromptBuilderChat components#1275
Conversation
…nd related components
✅ FOSSA Guard: Licensing (
|
✅ FOSSA Guard: Vulnerability (
|
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-1275! |
…pLayout for model configuration warnings
…ng rendering, message sending, and error handling
solace-pjones
approved these changes
Mar 27, 2026
Contributor
solace-pjones
left a comment
solace-pjones
left a comment
There was a problem hiding this comment.
Looks good. I just left a few comments.
| @@ -174,10 +177,15 @@ async def process_message( | |||
| ) | |||
| except Exception as e: | |||
Contributor
There was a problem hiding this comment.
I think this might all be dead code? It look like you can llm exceptions in the method _llm_response?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This change improves error handling and user experience in the prompt builder chat interface by properly identifying, displaying, and handling error states during AI interactions. It provides more robust error feedback to users instead of failing silently or crashing.
How was this change implemented?
Messageinterface to include anisErrorflag for visual indicationChatResponseto include error state tracking viais_errorflagPromptBuilderChat.tsxPromptBuilderAssistant.pyKey Design Decisions
This approach prioritizes graceful error handling and user feedback over simply throwing exceptions. By adding the
isErrorflag throughout the system, we can:How was this change tested?
Is there anything the reviewers should focus on/be aware of?
Please review the error recovery logic and ensure we're not suppressing critical errors that should interrupt the flow.
Before
After