fix(DATAGO-117142): adding await to ensure logout doesn't get logged immediately back in #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgh-solace
commented
Jan 5, 2026
| const handleLogoutClick = async () => { | ||
| setMenuOpen(false); | ||
| logout(); | ||
| await logout(); |
Collaborator
Author
There was a problem hiding this comment.
Adding the await here to stop logging in from immediately being triggered.
| <User className="size-4" /> | ||
| <span className="text-sm font-medium">{typeof userInfo?.username === "string" ? userInfo.username : "Guest"}</span> | ||
| <User className="size-4 shrink-0" /> | ||
| <div className="min-w-0 truncate text-sm font-medium" title={userName}> |
Collaborator
Author
There was a problem hiding this comment.
Long names should not overflow the container.
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-737! |
|
JKaram
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
How was this change implemented?
Adding await to ensure logout doesn't get logged immediately back in (via a useEffect re-rending) and truncating long names
How was this change tested?
Is there anything the reviewers should focus on/be aware of?