Skip to content

AI-657: Fix localhost CORS bug with web ui#77

Merged
RohanSreelesh merged 4 commits intodevfrom
rohan/ai-657/fix-localhost-webui
Apr 10, 2025
Merged

AI-657: Fix localhost CORS bug with web ui#77
RohanSreelesh merged 4 commits intodevfrom
rohan/ai-657/fix-localhost-webui

Conversation

@RohanSreelesh
Copy link
Collaborator

@RohanSreelesh RohanSreelesh commented Apr 7, 2025

What is the purpose of this change?

This is the documentation update that goes along with this PR SolaceLabs/solace-ai-connector-web#16. It also updates the default host for the web ui to be localhost

How is this accomplished?

Anything reviews should focus on/be aware of?

Copy link
Collaborator

@cyrus2281 cyrus2281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it's hosted? inside the container it would still be localhost, but in the brower it would have the container public URL

@RohanSreelesh
Copy link
Collaborator Author

What if it's hosted? inside the container it would still be localhost, but in the brower it would have the container public URL

@cyrus2281 I updated the advanced configuration docs to reflect how to configure for this case

@sonarqube-solacecloud
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Collaborator

@cyrus2281 cyrus2281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RohanSreelesh RohanSreelesh merged commit eb49f45 into dev Apr 10, 2025
9 checks passed
@RohanSreelesh RohanSreelesh deleted the rohan/ai-657/fix-localhost-webui branch April 10, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants