Skip to content

Conversation

@alorenzo175
Copy link
Contributor

a4 because pvlib/pvlib-python#1162 is required
along with a tbd issue for computing from effective irradiance

closes #119 closes #109

also adds real tests of the pvlib modelchain to catch errors there

a4 because pvlib/pvlib-python#1162 is required
along with a tbd issue for computing from effective irradiance

closes SolarPerformanceInsight#119 closes SolarPerformanceInsight#109

also adds real tests of the pvlib modelchain to catch errors there
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #124 (477e769) into main (71e5ea8) will decrease coverage by 0.37%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   91.68%   91.30%   -0.38%     
==========================================
  Files          75       75              
  Lines        2609     2669      +60     
  Branches      200      207       +7     
==========================================
+ Hits         2392     2437      +45     
- Misses        189      202      +13     
- Partials       28       30       +2     
Flag Coverage Δ
python 98.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/solarperformanceinsight_api/pvmodeling.py 100.00% <ø> (ø)
.../solarperformanceinsight_api/routers/parameters.py 100.00% <ø> (ø)
dashboard/src/api/jobs.ts 12.50% <0.00%> (-0.84%) ⬇️
dashboard/src/components/jobs/JobHandler.vue 90.90% <0.00%> (-3.11%) ⬇️
dashboard/src/components/jobs/JobResults.vue 32.92% <0.00%> (-3.08%) ⬇️
dashboard/src/components/jobs/data/Timeseries.vue 30.00% <0.00%> (-3.34%) ⬇️
api/solarperformanceinsight_api/compute.py 100.00% <100.00%> (ø)
api/solarperformanceinsight_api/conftest.py 100.00% <100.00%> (ø)
api/solarperformanceinsight_api/models.py 100.00% <100.00%> (ø)
.../src/components/jobs/parameters/TimeParameters.vue 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e5ea8...fa5e663. Read the comment docs.

@alorenzo175 alorenzo175 marked this pull request as ready for review February 8, 2021 19:46
@alorenzo175 alorenzo175 requested a review from wholmgren February 8, 2021 19:46
@alorenzo175 alorenzo175 merged commit 5db53ab into SolarPerformanceInsight:main Feb 8, 2021
@alorenzo175 alorenzo175 deleted the pvliba3 branch February 8, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single axis tracker systems with ghi, etc might fail to calculate update _modelchain_ac_model for multi array inverters

3 participants