-
Notifications
You must be signed in to change notification settings - Fork 86
Add drawPngFromBuffer #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrisjtwomey
wants to merge
1
commit into
SolderedElectronics:dev
Choose a base branch
from
chrisjtwomey:draw-from-png-buf
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -244,6 +244,53 @@ bool Image::drawPngFromWeb(const char *url, int x, int y, bool dither, bool inve | |
return ret; | ||
} | ||
|
||
/** | ||
* @brief drawPngFromBuffer function draws png image from buffer | ||
* | ||
* @param int32_t len | ||
* size of buffer | ||
* @param int x | ||
* x position for top left image corner | ||
* @param int y | ||
* y position for top left image corner | ||
* @param bool dither | ||
* 1 if using dither, 0 if not | ||
* @param bool invert | ||
* 1 if using invert, 0 if not | ||
* | ||
* @return 1 if drawn successfully, 0 if not | ||
*/ | ||
bool Image::drawPngFromBuffer(uint8_t *buf, int32_t len, int x, int y, bool dither, bool invert) | ||
{ | ||
if (!buf) | ||
return 0; | ||
|
||
_pngDither = dither; | ||
_pngInvert = invert; | ||
lastY = y; | ||
|
||
bool ret = 1; | ||
|
||
if (dither) | ||
memset(ditherBuffer, 0, sizeof ditherBuffer); | ||
|
||
pngle_t *pngle = pngle_new(); | ||
_pngX = x; | ||
_pngY = y; | ||
pngle_set_draw_callback(pngle, pngle_on_draw); | ||
|
||
if (!buf) | ||
return 0; | ||
|
||
if (pngle_feed(pngle, buf, len) < 0) | ||
ret = 0; | ||
|
||
pngle_destroy(pngle); | ||
free(buf); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neither |
||
return ret; | ||
} | ||
|
||
|
||
/** | ||
* @brief drawPngFromWeb function draws png image from sd file | ||
* | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate code, it's already defined further down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this up if the maintainers ever consider merging this. Personally I don't see why not but looks like they haven't merged any PRs from non-SolderedElectronics members in years...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to keep this earlier one rather than the one below. That prevents a possible memory leak from
pngle_new()
.