feat: Moved SearchbarMinItemsCount and UseBuiltInNames attribute properties to Project Settings

Author: SolidAlloy

Editor/Drawers/TypeDropdownDrawer.cs

@@ -29,7 +29,7 @@ public TypeDropdownDrawer(Type selectedType, TypeOptionsAttribute attribute, Typ
         public void Draw(Action<Type> onTypeSelected)
         {
             var dropdownItems = GetDropdownItems();
-            var selectionTree = new SelectionTree(dropdownItems, _selectedType, onTypeSelected, _attribute.SearchbarMinItemsCount, _attribute.ExcludeNone);
+            var selectionTree = new SelectionTree(dropdownItems, _selectedType, onTypeSelected, ProjectSettings.SearchbarMinItemsCount, _attribute.ExcludeNone);
 
             if (_attribute.ExpandAllFolders)
                 selectionTree.ExpandAllFolders();
@@ -81,7 +81,7 @@ private TypeItem[] GetFilteredTypes()
         {
             bool containsMSCorLib = false;
 
-            var typeRelatedAssemblies = _attribute.UseBuiltInNames
+            var typeRelatedAssemblies = ProjectSettings.UseBuiltInNames
                 ? TypeCollector.GetAssembliesTypeHasAccessTo(_declaringType, out containsMSCorLib)
                 : TypeCollector.GetAssembliesTypeHasAccessTo(_declaringType);
 
@@ -90,7 +90,7 @@ private TypeItem[] GetFilteredTypes()
 
             var filteredTypes = TypeCollector.GetFilteredTypesFromAssemblies(typeRelatedAssemblies, _attribute);
 
-            bool replaceBuiltInNames = _attribute.UseBuiltInNames && containsMSCorLib;
+            bool replaceBuiltInNames = ProjectSettings.UseBuiltInNames && containsMSCorLib;
 
             int filteredTypesLength = filteredTypes.Count;
 

Editor/Drawers/TypeFieldDrawer.cs

@@ -20,7 +20,6 @@ internal class TypeFieldDrawer
         private readonly SerializedTypeReference _serializedTypeRef;
         private readonly TypeDropdownDrawer _dropdownDrawer;
         private readonly bool _showShortName;
-        private readonly bool _useBuiltInNames;
         private readonly Rect _position;
         private readonly Action<Type> _onTypeSelected;
 
@@ -31,15 +30,13 @@ public TypeFieldDrawer(
             Rect position,
             TypeDropdownDrawer dropdownDrawer,
             bool showShortName,
-            bool useBuiltInNames,
             Action<Type> onTypeSelected = null,
             bool triggerDropdown = false)
         {
             _serializedTypeRef = serializedTypeRef;
             _position = position;
             _dropdownDrawer = dropdownDrawer;
             _showShortName = showShortName;
-            _useBuiltInNames = useBuiltInNames;
             _onTypeSelected = onTypeSelected;
             _triggerDropdown = triggerDropdown;
         }
@@ -124,7 +121,7 @@ private void DrawFieldContent(int controlID)
 
         private string GetTypeToShow(string typeName)
         {
-            if (_useBuiltInNames)
+            if (ProjectSettings.UseBuiltInNames)
             {
                 string builtInName = typeName.ReplaceWithBuiltInName();
                 if (builtInName != typeName)

Editor/Drawers/TypeReferencePropertyDrawer.cs

@@ -54,8 +54,7 @@ private void DrawTypeReferenceField(Rect position, SerializedProperty property)
                 serializedTypeRef,
                 position,
                 dropdownDrawer,
-                typeOptionsAttribute.ShortName,
-                typeOptionsAttribute.UseBuiltInNames);
+                typeOptionsAttribute.ShortName);
 
             fieldDrawer.Draw();
         }

Editor/ProjectSettings.cs

@@ -0,0 +1,48 @@
+namespace TypeReferences.Editor
+{
+    using UnityEditor.SettingsManagement;
+
+    internal static class ProjectSettings
+    {
+        private const string PackageName = "com.solidalloy.type-references";
+
+        private static Settings _instance;
+
+        private static UserSetting<int> _searchbarMinItemsCount;
+
+        public static int SearchbarMinItemsCount
+        {
+            get
+            {
+                InitializeIfNeeded();
+                return _searchbarMinItemsCount.value;
+            }
+
+            set => _searchbarMinItemsCount.value = value;
+        }
+
+        private static UserSetting<bool> _useBuiltInNames;
+
+        public static bool UseBuiltInNames
+        {
+            get
+            {
+                InitializeIfNeeded();
+                return _useBuiltInNames.value;
+            }
+
+            set => _useBuiltInNames.value = value;
+        }
+
+        private static void InitializeIfNeeded()
+        {
+            if (_instance != null)
+                return;
+
+            _instance = new Settings(PackageName);
+
+            _searchbarMinItemsCount = new UserSetting<int>(_instance, nameof(_searchbarMinItemsCount), 10);
+            _useBuiltInNames = new UserSetting<bool>(_instance, nameof(_useBuiltInNames), true);
+        }
+    }
+}

Editor/ProjectSettings.cs.meta

@@ -0,0 +1,53 @@
+namespace TypeReferences.Editor
+{
+    using System.Collections.Generic;
+    using SolidUtilities.Editor.Helpers;
+    using UnityEditor;
+    using UnityEngine;
+
+    internal static class ProjectSettingsDrawer
+    {
+        private const string SearchbarLabel = "Search bar minimum items count";
+        private const string SearchbarTooltip = "The minimum number of items in the drop-down for the search bar to appear.";
+
+        private const string BuiltInLabel = "Use built-in names";
+        private const string BuiltInTooltip = "Whether to make dropdown show built-in types by their keyword name (e.g. int) instead of the full name";
+
+        [SettingsProvider]
+        public static SettingsProvider CreateSettingsProvider()
+        {
+            return new SettingsProvider("Project/Type References", SettingsScope.Project)
+            {
+                guiHandler = OnGUI,
+                keywords = GetKeywords()
+            };
+        }
+
+        private static void OnGUI(string searchContext)
+        {
+            using var _ = EditorGUIUtilityHelper.LabelWidthBlock(220f);
+            ProjectSettings.SearchbarMinItemsCount = EditorGUILayout.IntField(new GUIContent(SearchbarLabel, SearchbarTooltip), ProjectSettings.SearchbarMinItemsCount, GUILayout.MaxWidth(300f));
+            ProjectSettings.UseBuiltInNames = EditorGUILayout.Toggle(new GUIContent(BuiltInLabel, BuiltInTooltip), ProjectSettings.UseBuiltInNames);
+        }
+
+        private static HashSet<string> GetKeywords()
+        {
+            var keywords = new HashSet<string>();
+            keywords.AddWords(SearchbarLabel);
+            keywords.AddWords(SearchbarTooltip);
+            keywords.AddWords(BuiltInLabel);
+            keywords.AddWords(BuiltInTooltip);
+            return keywords;
+        }
+
+        private static readonly char[] _separators = { ' ' };
+
+        private static void AddWords(this HashSet<string> set, string phrase)
+        {
+            foreach (string word in phrase.Split(_separators))
+            {
+                set.Add(word);
+            }
+        }
+    }
+}

Editor/ProjectSettingsDrawer.cs

@@ -4,7 +4,8 @@
     "references": [
         "GUID:ea6a6314f279f814facc8c48a7d3c9f1",
         "GUID:b73ef07971851e14fa74ae50b76f8225",
-        "GUID:48d58eaab94e1de429344393b7653b1f"
+        "GUID:48d58eaab94e1de429344393b7653b1f",
+        "GUID:49818357e697641afb75d2f8acaf1861"
     ],
     "includePlatforms": [
         "Editor"

Editor/ProjectSettingsDrawer.cs.meta

@@ -50,23 +50,12 @@ public class TypeOptionsAttribute : PropertyAttribute
         /// </summary>
         [PublicAPI] public bool ExpandAllFolders;
 
-        /// <summary>
-        /// Sets the minimum number of items in the drop-down for the search bar to appear. Defaults to 10.
-        /// </summary>
-        [PublicAPI] public int SearchbarMinItemsCount = 10;
-
         /// <summary>
         /// Makes the field show the short name of the selected type instead of the full one.
         /// <see langword="false"/> by default.
         /// </summary>
         [PublicAPI] public bool ShortName;
 
-        /// <summary>
-        /// Whether to make dropdown show built-in types by their keyword name (int) instead of the full name
-        /// (System.Int32). Defaults to <see langword="true"/>.
-        /// </summary>
-        [PublicAPI] public bool UseBuiltInNames = true;
-
         /// <summary>
         /// If enabled, shows only types that can be serialized by Unity. Defaults to <see langword="false"/>.
         /// </summary>

Editor/TypeReferences.Editor.asmdef

@@ -4,7 +4,8 @@
   "displayName": "Type References",
   "description": "A plugin that allows selecting a type from a drop-down menu in the inspector.",
   "dependencies": {
-    "com.solidalloy.util": "1.28.0"
+    "com.solidalloy.util": "1.28.0",
+    "com.unity.settings-manager": "1.0.3"
   },
   "keywords": [
     "dropdown",
@@ -25,4 +26,4 @@
       "path": "Samples~/Usage Examples"
     }
   ]
-}
+}