Fix TypeScript typing issues and improve singleton pattern implementation #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
bourgeoa
requested review from
Copilot and
timea-solid
and removed request for
Copilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces any types with proper TypeScript interfaces in the solid logic singleton pattern.
Changes
Fixed TypeScript compilation errors in solidLogicSingleton.ts
Added GlobalWithSingleton interface for proper global object typing
Replaced any with SolidLogic in singleton getter function
Before/After
Impact
✅ TypeScript compiles without errors
✅ Better type safety and IntelliSense
✅ No breaking changes
✅ All tests still pass
Type: Bug fix / Code quality
Version: 3.1.1