Skip to content

Conversation

@K0smalka
Copy link
Member

@K0smalka K0smalka commented Nov 30, 2025

Important

Refactors attribute handling in EmailService, FormService, and ParticipantService to improve block attribute validation and transformation.

  • Behavior:
    • Introduces getBlockDisplayValue() in EmailService to handle block attribute display values, returning "N/A" for invalid or non-existent blocks.
    • Refactors sendOnTrigger() in EmailService to use getBlockDisplayValue() for block attributes.
    • Updates parseContent() and parseContentLegacy() in EmailService to use getBlockDisplayValue() for block attributes.
  • Form Handling:
    • Adds normalization of attributes in submitForm() in FormService, filtering out null, "null", empty, and undefined values.
    • Validates block IDs in submitForm() in FormService, throwing exceptions for invalid formats or full blocks.
  • Participant Handling:
    • Adds prepareAttributesForSave() in ParticipantService to validate and transform block attributes, ensuring valid block IDs and existence.
    • Refactors createParticipant() and updateParticipant() in ParticipantService to use prepareAttributesForSave() for attribute handling.

This description was created by Ellipsis for 0f61653. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Member

@loudsheep loudsheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wygląda git

@K0smalka K0smalka requested review from loudsheep and removed request for GOLDER303 January 4, 2026 18:52
@K0smalka K0smalka linked an issue Jan 4, 2026 that may be closed by this pull request
@loudsheep loudsheep merged commit 725d4eb into main Jan 26, 2026
5 checks passed
@loudsheep loudsheep deleted the fix/attribute-pivot-validation branch January 26, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Walidacja attribute pivot value

3 participants