fix: prevent scrolling bug in digital guide

[24bartixx]

The issue was that the accesibility widget with cards was had circular progress indicator when it was loading data. Then the indicator was changing to SizedBox.shink()

1. height > 0
2. height = 0 or height >>> 0
3. weird jump

I implemented cache to store previous accesibility that is fetched asynchrounously causing this loading.
Moreover, I refactor the accesibiltiy list to load the card widgets lazily and used column instead of ListView (it's already inside CustomScrollView and there is not that many cards to render them dynamically imo) for perf.

---

Important

Implements caching and refactors accessibility list to prevent scrolling bug and improve performance in active_accessibility_modes_repository.dart.

• Behavior:
  • Implements caching in ActiveAccessibilityModesRepository to store previous accessibility data, preventing unnecessary re-fetching.
  • Refactors accessibility list to load card widgets lazily using Column instead of ListView for performance improvement.
• Repository:
  • Changes activeAccessibilityModesRepository to a class ActiveAccessibilityModesRepository with caching logic in active_accessibility_modes_repository.dart.

^{This description was created by for 77dd3d6. You can customize this summary. It will automatically update as commits are pushed.}

[simon-the-shark]

so this looks acceptable, but I would try one more thing to see if we could get same results without custom imperative cache, if you'd allow

[simon-the-shark]

why a function when it can be a private widget (this is builder methods anti-pattern)?

you can use inheritance if you don't want to repeat the build methods

class AccessibilityLevelCard extends AccessibilityInformationCard {
  _AccessibilityLevelCard({
    required BuildContext context,
    required String icon,
    required int level,
    required String? comment,
    required String peopleLabel,
    required String prefix,
    super.key,
  }) : super(
          icon: icon,
          color: DigitalGuideConfig.accessibilityLevelColors[level],
          text: comment ??
              context.localize.accessibility_card_information(
                prefix,
                accessibilityLevelType(level.toString()),
                peopleLabel,
              ),
        );
}

(or a new widget with build method is 100% ok as well)

[simon-the-shark]

instead of creating a method that returns a map I would just perfer to have a declarative-style switch (even inline in the build)

[simon-the-shark]

so I'm not saying that the cache you've built is not needed. It might be. We can go with it if it is needed truly. But could you try if something like that WITHOUT custom imperative cache that at least I believe should have very similar effects to what you've had done with the cache here:

switch (currentModesAsync) {
      AsyncError(:final error, :final stackTrace) => // error widget,
      AsyncValue(:final value) when value != null => buildCards(value) // this case should cover both, normal `AsyncData` case and `AsyncLoading` which has value from a previous render (that's how riverpod at least worked in the 2.0 version, not sure how about 3.0),
      _ => // actual loading cause no data is present (value == null), 
    };

afaik this should use the previous value even when refreshing so as far as i understand your code, very similar thing. not sure if 1:1 but very similar. could you try?

[simon-the-shark]

• if the keepAlive: true is crucial you should probably add it to activeAccessibilityModesRepository or whatever is needed

[24bartixx]

I managed to do this changing only riverpod repo