Skip to content

Conversation

@ibtyog
Copy link
Member

@ibtyog ibtyog commented Jul 31, 2025

do dodania przykład chain'a parametrów edit: jest


Important

Adds Standaryzacja API.mdx to document API standards for Eventownik V3, covering endpoint naming, response formats, error handling, GET parameters, authorization, headers, data serialization, documentation, testing, and file handling.

  • Documentation:
    • Adds Standaryzacja API.mdx to document API standards for Eventownik V3.
    • Covers endpoint naming, response and error formats, GET parameters, and authorization.
    • Details headers, data serialization, documentation practices, testing, and file handling.
  • Endpoint Naming:
    • Specifies structure: api, versioning, access level, resource name, functionality.
  • Response and Error Formats:
    • Responses in data object, pagination in metadata, POST/PUT return updated object, DELETE returns no content.
    • Errors use ZOD for request validation, appropriate status codes.
  • GET Parameters:
    • Pagination, sorting, filtering, relations, and select options detailed.
  • Authorization and Headers:
    • Cookie named "Authorization" with "Bearer ", JSON Web Token usage.
    • Headers include accept: application/json, request-id for tracing.
  • Data Serialization:
    • Dates in ISO 8601, resources in snake_case.
  • Documentation and Testing:
    • Uses Swagger, @ApiTags for grouping, CLI for annotations.
    • Testing with Jest and Supertest, focus on integration tests.
  • File Handling:
    • Uses multer for multipart/form-data, recommends metadata validation.

This description was created by Ellipsis for 83aa818. You can customize this summary. It will automatically update as commits are pushed.

@ibtyog ibtyog requested a review from dawidlinek July 31, 2025 15:09
Copy link
Member

@dawidlinek dawidlinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Z mojej strony tyle. Ogólnie mega dobra robota. @GOLDER303 daj znać co myślisz, bo trochę cię to ominęło

@dawidlinek dawidlinek requested a review from GOLDER303 August 6, 2025 18:53
@ibtyog
Copy link
Member Author

ibtyog commented Aug 7, 2025

naniosłem poprawi na resolved komentarze, czekam jeszcze na opinie przy pozostałych dwóch otwartych komentarzach @pb3dpb3d @GOLDER303

@dawidlinek
Copy link
Member

@GOLDER303

@dawidlinek
Copy link
Member

@GOLDER303 przydało by się to już ogarnąć

@Rei-x
Copy link
Member

Rei-x commented Sep 10, 2025

@GOLDER303 @dawidlinek co z tym? zamknijcie jak nie planujecie już nic robić

@ibtyog
Copy link
Member Author

ibtyog commented Sep 19, 2025

@GOLDER303 są poprawki można merge'ować

Copy link
Contributor

@GOLDER303 GOLDER303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibtyog jeszcze te dwie linijki tu trzeba zmienić, albo wywalić

@ibtyog ibtyog requested a review from GOLDER303 September 19, 2025 13:57
Copy link
Member

@dawidlinek dawidlinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dla mnie chyba ok, bo omawialiśmy to na spotkaniach

@ibtyog
Copy link
Member Author

ibtyog commented Sep 26, 2025

@GOLDER303 @dawidlinek pushnijcie bo permisji nie mam

@dawidlinek dawidlinek removed the request for review from GOLDER303 September 29, 2025 15:48
@dawidlinek
Copy link
Member

dawidlinek commented Sep 29, 2025

@GOLDER303 musisz zmienić na approve, bo inaczej blokuje

@dawidlinek dawidlinek merged commit 6188c98 into main Oct 5, 2025
1 check passed
@dawidlinek dawidlinek deleted the feat/standaryzacja-eventownik branch October 5, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants