Fix out of bounds exception on empty files#11
Open
simonbrandhof wants to merge 2 commits intomasterfrom
Open
Conversation
INFO: java.lang.ArrayIndexOutOfBoundsException: -1 INFO: at java.util.ArrayList.elementData(Unknown Source) INFO: at java.util.ArrayList.get(Unknown Source) INFO: at org.sonar.plugins.scm.mercurial.MercurialBlameCommand.blame(MercurialBlameCommand.java:104) INFO: at org.sonar.plugins.scm.mercurial.MercurialBlameCommand.access$000(MercurialBlameCommand.java:42) INFO: at org.sonar.plugins.scm.mercurial.MercurialBlameCommand$1.call(MercurialBlameCommand.java:83) INFO: at org.sonar.plugins.scm.mercurial.MercurialBlameCommand$1.call(MercurialBlameCommand.java:80) This happens if blame fails (e.g.) file not under version control and the source file has only one line of code
Codex-
reviewed
Apr 9, 2019
| CommandExecutor commandExecutor = mock(CommandExecutor.class); | ||
|
|
||
| when(commandExecutor.execute(any(), any(), any(), anyLong())).thenAnswer((Answer<Integer>) invocation -> { | ||
| // Hg doesn't blame last empty line |
There was a problem hiding this comment.
Given that the comment // SONARPLUGINS-3097 Mercurial do not report blame on last empty line already exists, is there a need for both? If so is the behaviour better described in a docstring instead of inline comment?
|
We're currently running into this issue. It's rather sad to see that there is a 6-year-old pull request to fix the issue, but that pull request has never been merged, because there is a potentially unnecessary comment in a unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See initial pull request : #9
Unit test has been added.