JS-106 Fix S3801: Detect calls to never-returning functions

[zglicz]

Summary

• Fix false positive in S3801 when a function ends with a call to a never-returning function
• The rule now recognizes that calling a function with return type never (e.g., a throwing helper) terminates the code path
• Requires the called function to have an explicit : never return type annotation (TypeScript infers void for unannotated throwing functions)

Test plan

• Added valid test cases for calling never-returning functions
• Added invalid test case for calling throwing function without : never annotation (documents limitation)
• All existing tests pass

🤖 Generated with Claude Code

[hashicorp-vault-sonar-prod]

JS-106

[github-actions]

Ruling Report

Code no longer flagged (7 issues)

S3801

ace/lib/ace/mode/html/saxparser.js:5100

  5098 | };
  5099 | 
> 5100 | TreeBuilder.prototype.insertIntoFosterParent = function(node) {
  5101 | 	var tableIndex = this.openElements.findIndex('table');
  5102 | 	var tableElement = this.openElements.item(tableIndex).node;

ace/lib/ace/mode/json/json_parse.js:106

   104 |         },
   105 | 
>  106 |         number = function () {
   107 | 
   108 | // Parse a number value.

ace/lib/ace/mode/json/json_parse.js:147

   145 |         },
   146 | 
>  147 |         string = function () {
   148 | 
   149 | // Parse a string value.

ace/lib/ace/mode/json/json_parse.js:199

   197 |         },
   198 | 
>  199 |         word = function () {
   200 | 
   201 | // true, false, or null.

ace/lib/ace/mode/json/json_parse.js:229

   227 |         value,  // Place holder for the value function.
   228 | 
>  229 |         array = function () {
   230 | 
   231 | // Parse an array value.

ace/lib/ace/mode/json/json_parse.js:256

   254 |         },
   255 | 
>  256 |         object = function () {
   257 | 
   258 | // Parse an object value.

desktop/app/src/ui/local-changes-overwritten/local-changes-overwritten-dialog.tsx:157

   155 |    * Returns a user-friendly string to describe the current retryAction.
   156 |    */
>  157 |   private getRetryActionName() {
   158 |     switch (this.props.retryAction.type) {
   159 |       case RetryActionType.Checkout:

---

✅ Ruling has been updated. To re-run CI, either:

• Close and reopen this PR, or
• Run: git pull && git commit --allow-empty -m 'Trigger CI' && git push

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube