Skip to content

JS-1097 Fix FP on S6775: PropTypes not tracked through spread of separate constants #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ss-vibe-bot wants to merge 10 commits into
base: master
Choose a base branch
from
Open

JS-1097 Fix FP on S6775: PropTypes not tracked through spread of separate constants #6309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b65194
Add failing tests for S6775 false positive
Feb 2, 2026
b58acd4
Fix FP for S6775
Feb 2, 2026
d2e7602
Sync expected ruling files after rule-specific refinement
Feb 2, 2026
bd9a80c
Address PR comment from github-actions[bot]
Feb 2, 2026
4b93745
Address SonarQube issues in S6775 decorator
Feb 2, 2026
5f56186
Add test coverage for S6775 decorator
francois-mora-sonarsource Feb 3, 2026
ce84fee
Achieve 100% code coverage for S6775 decorator
francois-mora-sonarsource Feb 5, 2026
00f03e0
Remove COVERAGE_IMPROVEMENT_GUIDE.md
francois-mora-sonarsource Feb 5, 2026
5dc043f
Fix SonarQube code quality issues in S6775 decorator
francois-mora-sonarsource Feb 5, 2026
5e7ede9
Fix S121 missing curly braces in S6775 decorator
Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions packages/.sonar-analysis/external-issues.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
[
{
"rule": "typescript:S121",
"component": "org.sonarsource.javascript:javascript:packages/jsts/src/rules/S6775/decorator.ts",
"line": 263,
"message": "Expected { after 'if' condition.",
"textRange": {
"startLine": 263,
"endLine": 263,
"startOffset": 50,
"endOffset": 59
}
},
{
"rule": "typescript:S121",
"component": "org.sonarsource.javascript:javascript:packages/jsts/src/rules/S6775/decorator.ts",
"line": 284,
"message": "Expected { after 'if' condition.",
"textRange": {
"startLine": 284,
"endLine": 284,
"startOffset": 21,
"endOffset": 38
}
},
{
"rule": "typescript:S121",
"component": "org.sonarsource.javascript:javascript:packages/jsts/src/rules/S6775/decorator.ts",
"line": 363,
"message": "Expected { after 'if' condition.",
"textRange": {
"startLine": 363,
"endLine": 363,
"startOffset": 19,
"endOffset": 36
}
},
{
"rule": "typescript:S121",
"component": "org.sonarsource.javascript:javascript:packages/jsts/src/rules/S6775/decorator.ts",
"line": 376,
"message": "Expected { after 'if' condition.",
"textRange": {
"startLine": 376,
"endLine": 376,
"startOffset": 19,
"endOffset": 36
}
}
]
2 changes: 1 addition & 1 deletion packages/jsts/src/rules/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,6 @@ SonarJS uses some rules are not shipped in this ESLint plugin to avoid duplicati
| [S6770](https://sonarsource.github.io/rspec/#/rspec/S6770/javascript) | [react/jsx-pascal-case](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/jsx-pascal-case.md) |
| [S6772](https://sonarsource.github.io/rspec/#/rspec/S6772/javascript) | [react/jsx-child-element-spacing](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/jsx-child-element-spacing.md) |
| [S6774](https://sonarsource.github.io/rspec/#/rspec/S6774/javascript) | [react/prop-types](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/prop-types.md) |
| [S6775](https://sonarsource.github.io/rspec/#/rspec/S6775/javascript) | [react/default-props-match-prop-types](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/default-props-match-prop-types.md) |
| [S6789](https://sonarsource.github.io/rspec/#/rspec/S6789/javascript) | [react/no-is-mounted](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/no-is-mounted.md) |
| [S6790](https://sonarsource.github.io/rspec/#/rspec/S6790/javascript) | [react/no-string-refs](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/no-string-refs.md) |
| [S6793](https://sonarsource.github.io/rspec/#/rspec/S6793/javascript) | [jsx-a11y/aria-proptypes](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/aria-proptypes.md) |
Expand Down Expand Up @@ -648,6 +647,7 @@ The following rules are used in SonarJS but not available in this ESLint plugin.
| [S6747](https://sonarsource.github.io/rspec/#/rspec/S6747/javascript) | [react/no-unknown-property](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/no-unknown-property.md)<br>[jsx-a11y/aria-props](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/aria-props.md) |
| [S6749](https://sonarsource.github.io/rspec/#/rspec/S6749/javascript) | [react/jsx-no-useless-fragment](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/jsx-no-useless-fragment.md) |
| [S6754](https://sonarsource.github.io/rspec/#/rspec/S6754/javascript) | [react/hook-use-state](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/hook-use-state.md) |
| [S6775](https://sonarsource.github.io/rspec/#/rspec/S6775/javascript) | [react/default-props-match-prop-types](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/default-props-match-prop-types.md) |
| [S6788](https://sonarsource.github.io/rspec/#/rspec/S6788/javascript) | [react/no-find-dom-node](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/no-find-dom-node.md) |
| [S6791](https://sonarsource.github.io/rspec/#/rspec/S6791/javascript) | [react/no-unsafe](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/docs/rules/no-unsafe.md) |
| [S6827](https://sonarsource.github.io/rspec/#/rspec/S6827/javascript) | [jsx-a11y/anchor-has-content](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-has-content.md) |
Expand Down
Loading
Loading