JS-1227 perf: Optimize S125 commented-out code detection#6340
Open
JS-1227 perf: Optimize S125 commented-out code detection#6340
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
Contributor
Ruling Report✅ No changes to ruling expected issues in this PR |
vdiez
force-pushed
the
perf/optimize-S125-commented-code-detection
branch
2 times, most recently
from
898011d to
7d1e2d1
Compare
Add cheap regex prefilter before recognizer/parser pipeline, defer SourceCode construction, short-circuit couldBeJsCode, pre-compile regex in ContainsDetector, and replace per-char regex with Set lookup in EndWithDetector. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdiez
force-pushed
the
perf/optimize-S125-commented-code-detection
branch
from
9257360 to
6e2cbca
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/[;{}()=<>]/) before the recognizer+parser pipeline — skips the entire expensive path for comments that can't possibly be JS codenew SourceCode()construction — only build it whengetLastTokenis actually needed, avoiding expensive token indexing for most commentscouldBeJsCode— use.some()instead of.filter().lengthto bail on first matching lineContainsDetector— avoidnew RegExp()on everyscan()call per line (also fixed missinggflag inreplaceAll)EndWithDetectorwith aSetchar-code lookupinjectMissingBraces— single-pass loop instead of twomatch()calls + array allocationsTest plan
🤖 Generated with Claude Code