Skip to content

GHA-79 Add UTs for PullRequestClosed #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 11, 2025
Merged

GHA-79 Add UTs for PullRequestClosed #236

merged 6 commits into from
Aug 11, 2025

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Aug 7, 2025 •
edited by atlassian bot
Loading

@mary-georgiou-sonarsource mary-georgiou-sonarsource requested a review from a team as a code owner August 7, 2025 14:18
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft August 7, 2025 14:18
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the base branch from master to Pavel/02-Created August 7, 2025 14:19
@mary-georgiou-sonarsource mary-georgiou-sonarsource removed the request for review from a team August 7, 2025 14:19
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title GHA-79 Add UTs for PullRequestClosed GHA-79 Add UTs for PullRequestClosed Aug 7, 2025
Base automatically changed from Pavel/02-Created to master August 7, 2025 14:35
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/pullreqclosed branch 3 times, most recently from 9260d48 to a363b26 Compare August 11, 2025 07:15
@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as ready for review August 11, 2025 07:17
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/pullreqclosed branch 2 times, most recently from 378da2f to f4a8ed6 Compare August 11, 2025 07:31
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some testcases were not covered

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently miss clicked :D

@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/pullreqclosed branch 5 times, most recently from 22283f7 to 8a4b50f Compare August 11, 2025 12:41
pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round

@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/pullreqclosed branch 2 times, most recently from 46f6b06 to d89e2d6 Compare August 11, 2025 13:48
pavel-mikula-sonarsource
pavel-mikula-sonarsource reviewed Aug 11, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

🤖 Pull Request summary

Adds test coverage for PullRequestClosed functionality.

• Comprehensive test suite for the PullRequestClosed action with 9 test cases covering various scenarios
• Minor bug fix in TypeScript: adds null fallback for issue creator field access to prevent undefined errors
• Test infrastructure updates including enhanced stubs for Jira client and Octokit with additional mock data
• Generated JavaScript dist files and source maps from TypeScript compilation

Review focus: The null coalescing operator change (|| null) in the creator field access - verify this handles the case where issue.fields.creator.displayName might be undefined without breaking existing functionality.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 69dc4dc into master Aug 11, 2025
6 of 7 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the mary/pullreqclosed branch August 11, 2025 15:09
@mary-georgiou-sonarsource mary-georgiou-sonarsource restored the mary/pullreqclosed branch August 11, 2025 15:23
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the mary/pullreqclosed branch August 12, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mary-georgiou-sonarsource @pavel-mikula-sonarsource