Skip to content

GHA-86 PREQ: Do not assign tickets #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

GHA-86 PREQ: Do not assign tickets #242

merged 1 commit into from
Aug 11, 2025

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Aug 8, 2025 •
edited by atlassian bot
Loading

@pavel-mikula-sonarsource pavel-mikula-sonarsource requested a review from a team as a code owner August 8, 2025 11:41
mary-georgiou-sonarsource
mary-georgiou-sonarsource reviewed Aug 11, 2025
View reviewed changes
PullRequestCreated/PullRequestCreated.test.ts
@@ -204,7 +204,6 @@ describe('PullRequestCreated', () => {
"Invoked jira.addIssueRemoteLink('PREQ-4242'', 'https://github.com/test-owner/test-repo/pull/42', null)",
"Invoked jira.moveIssue('PREQ-4242', 'Commit', null)",
"Invoked jira.moveIssue('PREQ-4242', 'Start', null)",
"Invoked jira.assignIssueToAccount('PREQ-4242', '1234-account')",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to add a dedicetated test "Is PREQ assignee is null"?

Copy link
Contributor Author

@pavel-mikula-sonarsource pavel-mikula-sonarsource Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the crazy inner logic of NewIssueData is tested in NewIssueData.test.ts

mary-georgiou-sonarsource
mary-georgiou-sonarsource reviewed Aug 11, 2025
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment about addind a dedicated test

@sonarqubecloud SonarQubeCloud
Copy link

🤖 Pull Request summary

Decouples Jira issue assignment from account-based workflow status transitions.

• Separates assignment logic: Splits accountId (for workflow transitions) from assigneeId (for issue assignment)
• Conditional assignment: Issue assignment now only occurs when assigneeId is present, independent of account status
• PREQ project handling: External contributors to PREQ projects are no longer auto-assigned (assigneeId set to null)
• Test updates: Removes expectation for automatic assignment call in one test scenario

Focus areas for review:

  • Verify the separation of workflow vs assignment logic doesn't break existing behavior
  • Confirm PREQ project assignment rules align with intended business logic
  • Check that the conditional assignment properly handles edge cases with null/undefined values

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ ok

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 9653806 into master Aug 11, 2025
6 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the Pavel/GHA-86-PREQ-Assignee branch August 11, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavel-mikula-sonarsource @mary-georgiou-sonarsource