Skip to content

GHA-193 Update for sonar-java: use latest rule-api and add post-update step#100

Merged
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
tt/update-rule-metadata
Feb 25, 2026
Merged

GHA-193 Update for sonar-java: use latest rule-api and add post-update step#100
tomasz-tylenda-sonarsource merged 2 commits intomasterfrom
tt/update-rule-metadata

Conversation

@tomasz-tylenda-sonarsource
Copy link
Contributor

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Features for sonar-java: use latest rule-api and add post-update step. GHA-193 Features for sonar-java: use latest rule-api and add post-update step. Feb 25, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Feb 25, 2026

GHA-193

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource force-pushed the tt/update-rule-metadata branch 3 times, most recently from e1441d9 to cf6938e Compare February 25, 2026 10:41
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title GHA-193 Features for sonar-java: use latest rule-api and add post-update step. GHA-193 Update for sonar-java: use latest rule-api and add post-update step Feb 25, 2026
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource force-pushed the tt/update-rule-metadata branch 2 times, most recently from d4cf666 to b035507 Compare February 25, 2026 13:02
Copy link
Contributor

@nils-werner-sonarsource nils-werner-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks also for the 2 hardcoded STL specific things.

@sonarqubecloud
Copy link

SonarQube reviewer guide

Review in SonarQube

Summary: Enhance the update-rule-metadata action with flexible rule-api versioning, configurable RSpec token suffix, additional post-update hooks, and customizable PR labels.

Review Focus:

  • The rule-api version handling now supports downloading the latest release when empty (lines 60-74 in action.yml). Ensure the jfrog CLI integration and manifest parsing are robust.
  • New rspec-token-suffix input allows dynamic vault secret paths, requiring careful review of the GitHub Actions string interpolation in both files.
  • The post-update script execution (lines 189-192) runs arbitrary user input—verify this doesn't introduce security risks.

Start review at: update-rule-metadata/action.yml. This file defines all new inputs and orchestrates the core workflow changes, making it essential to understand the contract and flow before reviewing the implementation details in the workflow test file.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tomasz-tylenda-sonarsource
Copy link
Contributor Author

We discussed this change offline and decide to merge as is.

The action could be simplified in future if we standardize rspec token suffix.

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 3238990 into master Feb 25, 2026
11 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/update-rule-metadata branch February 25, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants