Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2025

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@egon-okerman-sonarsource egon-okerman-sonarsource marked this pull request as ready for review August 8, 2025 15:46
@egon-okerman-sonarsource egon-okerman-sonarsource changed the title Create rule S7485 Modify rule S7485: add Swift (SONARSEC-685) Aug 8, 2025
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM but the adoc syntax is broken where the :platform-explanation: substitution is defined. I suggested a fix.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egon-okerman-sonarsource egon-okerman-sonarsource added this pull request to the merge queue Aug 21, 2025
Merged via the queue into master with commit 65e6267 Aug 21, 2025
13 of 14 checks passed
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the rule/S7485-add-swift branch August 21, 2025 14:31
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Modify rule S7485: add Swift (SONARSEC-685) Modify rule S7485: add Swift (SONARSWIFT-685) Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants