Skip to content

Create rule S8378(js): DOM-based XPath injection (implied client-side) #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loris-s-sonarsource merged 9 commits into from
Jan 19, 2026
Merged

Create rule S8378(js): DOM-based XPath injection (implied client-side) #6019

loris-s-sonarsource merged 9 commits into from
Jan 19, 2026

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2026

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the jsts label Jan 6, 2026
@loris-s-sonarsource loris-s-sonarsource changed the title Create rule S8378 Create rule S8378(js): DOM-based XPath injection (implied client-side) Jan 6, 2026
loris-s-sonarsource
loris-s-sonarsource reviewed Jan 8, 2026
View reviewed changes
@loris-s-sonarsource loris-s-sonarsource marked this pull request as ready for review January 8, 2026 16:04
andrey-tyukin-sonarsource
andrey-tyukin-sonarsource reviewed Jan 9, 2026
View reviewed changes
renaud-tognelli-sonarsource
renaud-tognelli-sonarsource requested changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@renaud-tognelli-sonarsource renaud-tognelli-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some content that seems unrelated, but overall is good. 🚀

@loris-s-sonarsource @renaud-tognelli-sonarsource
Apply suggestions from code review
5914506 
Co-authored-by: Renaud T. <125455319+renaud-tognelli-sonarsource@users.noreply.github.com>
@sonarqube-next
Copy link

sonarqube-next bot commented Jan 9, 2026

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

sonarqube-next bot commented Jan 9, 2026

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

loris-s-sonarsource
loris-s-sonarsource reviewed Jan 19, 2026
View reviewed changes
alessandro-mizzaro-sonarsource
alessandro-mizzaro-sonarsource approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@alessandro-mizzaro-sonarsource alessandro-mizzaro-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqube-next
Copy link

sonarqube-next bot commented Jan 19, 2026

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next
Copy link

sonarqube-next bot commented Jan 19, 2026

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

renaud-tognelli-sonarsource
renaud-tognelli-sonarsource approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@renaud-tognelli-sonarsource renaud-tognelli-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loris-s-sonarsource loris-s-sonarsource added this pull request to the merge queue Jan 19, 2026
Merged via the queue into master with commit a1c4ee3 Jan 19, 2026
11 of 13 checks passed
@loris-s-sonarsource loris-s-sonarsource deleted the rule/add-RSPEC-S8378 branch January 19, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrey-tyukin-sonarsource andrey-tyukin-sonarsource andrey-tyukin-sonarsource left review comments

@loris-s-sonarsource loris-s-sonarsource loris-s-sonarsource left review comments

@renaud-tognelli-sonarsource renaud-tognelli-sonarsource renaud-tognelli-sonarsource approved these changes

@alessandro-mizzaro-sonarsource alessandro-mizzaro-sonarsource alessandro-mizzaro-sonarsource approved these changes

Assignees

@loris-s-sonarsource loris-s-sonarsource

Labels

jsts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrey-tyukin-sonarsource @loris-s-sonarsource @renaud-tognelli-sonarsource @alessandro-mizzaro-sonarsource