JAVASE-144 Bootstrap GHA for sonar-java-symbolic-execution#40
JAVASE-144 Bootstrap GHA for sonar-java-symbolic-execution#40GabrielFleischer merged 2 commits intomasterfrom
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
GabrielFleischer
force-pushed
the
gfleischer/gha-migration
branch
2 times, most recently
from
df5af95 to
fda7ac0
Compare
| qa: | ||
| needs: [build] | ||
| runs-on: github-ubuntu-latest-l | ||
| if: github.event_name != 'pull_request' || (github.event.pull_request.head.repo.full_name == github.repository && github.actor != 'dependabot[bot]') |
There was a problem hiding this comment.
Is this needed?
There was a problem hiding this comment.
I think it prevents QA from being executed on a fork.
Given that we maintain the runners, I think so.
There was a problem hiding this comment.
Maybe we could discuss it offile at some point. This should be consistent across out repos and other squads.
|
|
||
| promote: | ||
| name: Promote | ||
| needs: [build, qa] |
There was a problem hiding this comment.
Did you consider doing build (plus night and cleanup) separately from qa?
There was a problem hiding this comment.
I am not sure I understand
There was a problem hiding this comment.
I meant separate PRs.
There was a problem hiding this comment.
I have a preference for smaller tasks, so that we could start building while we are ironing out the details of QA. We can keep it one PR if you prefer.
There was a problem hiding this comment.
The PR is complete, I don't think the work needed to split it outweigh the gain.
But if you have a strong view on this, I can split it.
GabrielFleischer
force-pushed
the
gfleischer/gha-migration
branch
from
10f7473 to
79ab8a9
Compare
GabrielFleischer
force-pushed
the
gfleischer/gha-migration
branch
from
79ab8a9 to
4fc26fb
Compare
|
2 participants
JAVASE-144
Part of BUILD-8404