Skip to content

JAVASE-145 Use regular project key instead of shadow project key for shadow scans#41

Merged
dorian-burihabwa-sonarsource merged 1 commit intomasterfrom
db/JAVASE-145
Oct 23, 2025
Merged

JAVASE-145 Use regular project key instead of shadow project key for shadow scans#41
dorian-burihabwa-sonarsource merged 1 commit intomasterfrom
db/JAVASE-145

Conversation

@dorian-burihabwa-sonarsource
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource commented Oct 22, 2025 •
edited by atlassian bot
Loading

@dorian-burihabwa-sonarsource
JAVASE-145 Use regular project key instead of shadow project key
5f42426 
Project keys have been aligned across all platforms.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqube-cloud-us
Copy link

sonarqube-cloud-us bot commented Oct 22, 2025

SonarQube reviewer guide

Summary: Disables nightly-only execution and consolidates project keys in shadow scan configuration.

Review Focus: The removal of the SHADOW_PROJECT_KEY environment variable and its replacement with SONAR_PROJECT_KEY throughout the codebase. Also, the commented-out execution condition may cause the task to run more frequently than intended.

Start review at: .cirrus.yml. This file contains the CI configuration changes that control when the task runs and defines the environment variables used by the shell script.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Please remember to uncomment the line you commented out for testing.

@dorian-burihabwa-sonarsource
Copy link
Contributor Author

dorian-burihabwa-sonarsource commented Oct 23, 2025

LGMT. Please remember to uncomment the line you commented out for testing.

The commented guard has been restored. The PR should automerge once you approve

@sonarqube-next
Copy link

sonarqube-next bot commented Oct 23, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource merged commit 71ec783 into master Oct 23, 2025
8 checks passed
@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource deleted the db/JAVASE-145 branch October 23, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dorian-burihabwa-sonarsource @tomasz-tylenda-sonarsource