SONARJAVA-5153: S1989 should not raise issue if exception is caught by try/catch block #5314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation was adding/removing exception tracking clauses from opposite sides of the stack. Meaning, that the wrong exception clauses got removed in the case of nested try-catch code.
anton-haubner-sonarsource
force-pushed
the
SONARJAVA-5153
branch
from
5b4dbd1 to
9776230
Compare
|
anton-haubner-sonarsource
requested a review
from leonardo-pilastri-sonarsource
leonardo-pilastri-sonarsource
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing commit-by-commit is recommended.