Skip to content

SONARJAVA-5845 Add new ModuleMetadata public API #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonardo-pilastri-sonarsource merged 5 commits into from
Nov 21, 2025
Merged

SONARJAVA-5845 Add new ModuleMetadata public API #5343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73192ad
SONARJAVA-5845 Add new ModuleMetadata public API
leonardo-pilastri-sonarsource Nov 4, 2025
42902e9
Improve coverage
leonardo-pilastri-sonarsource Nov 6, 2025
30fef41
Avoid accessing SonarComponents at injection time to prevent NPE
leonardo-pilastri-sonarsource Nov 11, 2025
77f09c9
Improve coverage
leonardo-pilastri-sonarsource Nov 20, 2025
dd13053
Review changes
leonardo-pilastri-sonarsource Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ks-test-sources/default/src/test/java/checks/tests/SpringBootEmptyMethodsCheckSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
class SpringBootSanityTest {
// Compliant, first time we encounter a spring sanity test
@Test
void contextLoads() {}
void contextLoads() {
}

// Noncompliant@+2
@Test
Expand Down
15 changes: 15 additions & 0 deletions java-frontend/src/test/java/org/sonar/java/model/JavaVersionImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@
*/
package org.sonar.java.model;

import java.util.Optional;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.sonar.api.config.Configuration;
import org.sonar.plugins.java.api.JavaVersion;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;

class JavaVersionImplTest {

Expand Down Expand Up @@ -182,5 +186,16 @@ void test_fromMap() {
assertThat(version.asInt()).isEqualTo(-1);
assertThat(version.arePreviewFeaturesEnabled()).isFalse();
}

@Test
void test_preview_features_without_max_version_from_config(){
var config = mock(Configuration.class);
doReturn(Optional.of("17")).when(config).get(JavaVersion.SOURCE_VERSION);
doReturn(Optional.of("true")).when(config).get(JavaVersion.ENABLE_PREVIEW);
var javaVersion = JavaVersionImpl.readFromConfiguration(config);
assertThat(javaVersion.asInt()).isEqualTo(17);
// Preview features should be disabled because 17 is not the max supported version
assertThat(javaVersion.arePreviewFeaturesEnabled()).isFalse();
}

}